NAPPS-2465: updating packages in dockerfile for wiz fix #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kat-Alo
requested review from
paigemoody and
karenswang
and removed request for
a team
jtotoole
reviewed
Nov 14, 2023
| @@ -3,6 +3,9 @@ FROM public.ecr.aws/docker/library/ruby:2.7.7 | |||
| # Throw errors if Gemfile has been modified since Gemfile.lock | |||
| RUN bundle config --global frozen 1 | |||
|
|
|||
| # Updating packages | |||
| RUN apt update && apt upgrade -yqq | |||
There was a problem hiding this comment.
@jakekara do we want to say apt-get over apt across projects now? https://github.com/WPMedia/policeshootings/pull/592#pullrequestreview-1727678201
There was a problem hiding this comment.
Whichever works. Depends on the OS the base image is using which tools are installed. In this case, apt is fine.
Kat-Alo
requested review from
jakekara and
jtotoole
and removed request for
paigemoody and
karenswang
jakekara
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than the fixes prescribed in the ticket, which call for updating packages that aren't installed, the team has moved to instead update all installed packages like so.
To test:
docker-compose downdocker-compose builddocker-compose upConfirm the app loads at localhost:3001/klaxon